Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating retrieval for multion sdk changes #281

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Jul 1, 2024

MultiOn updated the location of their retrieval function in their sdk so updating our corresponding example

@HowieG HowieG requested review from siyangqiu and bboynton97 July 1, 2024 20:18
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 42.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bboynton97
Copy link
Contributor

just a notebook change?

@HowieG
Copy link
Contributor Author

HowieG commented Jul 1, 2024

just a notebook change?

yes

@HowieG HowieG enabled auto-merge (squash) July 1, 2024 20:40
@bboynton97
Copy link
Contributor

why

@bboynton97
Copy link
Contributor

pls clear outputs, there's a ton of unnecessary text rn

@HowieG
Copy link
Contributor Author

HowieG commented Jul 2, 2024

why

The description explains why

@HowieG
Copy link
Contributor Author

HowieG commented Jul 2, 2024

pls clear outputs, there's a ton of unnecessary text rn

Done. I had cleared outputs but VSCode's been finicky

@HowieG HowieG merged commit 3e54c42 into main Jul 3, 2024
10 checks passed
@HowieG HowieG deleted the update-multion-retrieval branch July 3, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants